-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Fix invisible footer for light mode users across default templates #4056
base: v3-alpha
Are you sure you want to change the base?
[v3] Fix invisible footer for light mode users across default templates #4056
Conversation
Signed-off-by: Marcus Crane <[email protected]>
WalkthroughThe changes remove the explicit color definition for the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (19)
💤 Files with no reviewable changes (18)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
Thanks for this 🙏 Please could you add an entry to the changelog located at |
Signed-off-by: Marcus Crane <[email protected]>
Added a changelog entry |
Description
This PR is a follow up in the same vein as #3477 which was previously discussed in Discord here.
I was a bit confused scaffolding a new project as I saw references to the time event but had spotted no such thing.
It turns out that the styling for the footer, on certain screens with high brightness most likely, renders the content invisible when using "Light Mode" which I do.
Here's a comparison between Light and Dark mode although the issue might be less pronounced on different displays:
It's worth noting that while I've confirmed this fix using the
vanilla
template, I've assumed that each other template should have the same issue but I haven't explicitly checked each one.I'm happy to do that if requested though.
Here's a screenshot with the fix applied:
Fixes #3471
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit