Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Fix invisible footer for light mode users across default templates #4056

Open
wants to merge 2 commits into
base: v3-alpha
Choose a base branch
from

Conversation

marcus-crane
Copy link
Contributor

@marcus-crane marcus-crane commented Feb 10, 2025

Description

This PR is a follow up in the same vein as #3477 which was previously discussed in Discord here.

I was a bit confused scaffolding a new project as I saw references to the time event but had spotted no such thing.

It turns out that the styling for the footer, on certain screens with high brightness most likely, renders the content invisible when using "Light Mode" which I do.

Here's a comparison between Light and Dark mode although the issue might be less pronounced on different displays:

CleanShot 2025-02-10 at 15 30 42

CleanShot 2025-02-10 at 15 30 44

It's worth noting that while I've confirmed this fix using the vanilla template, I've assumed that each other template should have the same issue but I haven't explicitly checked each one.

I'm happy to do that if requested though.

Here's a screenshot with the fix applied:

CleanShot 2025-02-10 at 15 52 49@2x

Fixes #3471

Type of change

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

 Wails (v3.0.0-alpha.9)  Wails Doctor

# System

┌──────────────────────────────────────────────────┐
| Name          | MacOS                            |
| Version       | 15.3                             |
| ID            | 24D60                            |
| Branding      | MacOS 15.3                       |
| Platform      | darwin                           |
| Architecture  | arm64                            |
| Apple Silicon | true                             |
| CPU           | Apple M2 Max                     |
| CPU 1         | Apple M2 Max                     |
| CPU 2         | Apple M2 Max                     |
| GPU           | 30 cores, Metal Support: Metal 3 |
| Memory        | 32 GB                            |
└──────────────────────────────────────────────────┘

# Build Environment

┌───────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.9 |
| Go Version   | go1.23.4       |
| -buildmode   | exe            |
| -compiler    | gc             |
| CGO_CFLAGS   |                |
| CGO_CPPFLAGS |                |
| CGO_CXXFLAGS |                |
| CGO_ENABLED  | 1              |
| CGO_LDFLAGS  |                |
| GOARCH       | arm64          |
| GOARM64      | v8.0           |
| GOOS         | darwin         |
└───────────────────────────────┘

# Dependencies

┌────────────────────────────────────────────────────────────────────────┐
| Xcode cli tools | 2409                                                 |
| npm             | 10.9.2                                               |
| *NSIS           | Not Installed. Install with `brew install makensis`. |
└─────────────────────── * - Optional Dependency ────────────────────────┘

# Checking for issues

 SUCCESS  No issues found

# Diagnosis

 SUCCESS  Your system is ready for Wails development!

Need documentation? Run: wails3 docs
 ♥   If Wails is useful to you or your company, please consider sponsoring the project: wails3 sponsor

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Style
    • Removed an explicit footer text color, allowing the footer to inherit its color from parent or default styles.
    • Added a margin to result elements to improve vertical spacing and layout consistency.
  • Bug Fixes
    • Fixed issue with non-React templates failing to display the "Hello World" footer when using a light system color scheme.

Copy link
Contributor

coderabbitai bot commented Feb 10, 2025

Walkthrough

The changes remove the explicit color definition for the .footer class (previously set to rgba(255, 255, 255, 0.67)) in multiple CSS and style files across various project templates. One file also adds a margin property to the .result class. These modifications adjust the visual styling by relying on inherited or default colors without altering functionality or exported entities.

Changes

File(s) Change Summary
v3/examples/…/public/style.css,
v3/internal/templates/{lit-ts,lit}/…/my-element.(ts
js),
v3/internal/templates/{preact,qwik,solid,svelte,sveltekit,vanilla,vue}/…/public/style.css
v3/internal/templates/preact-ts/…/public/style.css Removed the .footer color property and added a new margin property (margin: 1.5rem auto;) to the .result class.

Possibly related PRs

  • chore: fix DeskGap author link on credits page #3724: The changes in the main PR, which involve the removal of the color property for the .footer class in a CSS file, are directly related to the modifications in multiple retrieved PRs that also remove the same color property from the .footer class in various CSS files. Therefore, they are strongly connected at the code level.

Suggested reviewers

  • leeanthony

Poem

I'm a bunny with a hop so light,
Saying goodbye to white footer might,
Colors now flow as defaults play,
Margin added to brighten the day,
Happy paws tap in pure delight! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c85b10 and 56a6b2a.

📒 Files selected for processing (19)
  • docs/src/content/docs/changelog.mdx (1 hunks)
  • v3/examples/file-association/frontend/public/style.css (0 hunks)
  • v3/internal/templates/lit-ts/frontend/src/my-element.ts (0 hunks)
  • v3/internal/templates/lit/frontend/src/my-element.js (0 hunks)
  • v3/internal/templates/preact-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/preact/frontend/public/style.css (0 hunks)
  • v3/internal/templates/qwik-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/qwik/frontend/public/style.css (0 hunks)
  • v3/internal/templates/solid-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/solid/frontend/public/style.css (0 hunks)
  • v3/internal/templates/svelte-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/svelte/frontend/public/style.css (0 hunks)
  • v3/internal/templates/sveltekit-ts/frontend/static/style.css (0 hunks)
  • v3/internal/templates/sveltekit/frontend/frontend/style.css (0 hunks)
  • v3/internal/templates/sveltekit/frontend/static/style.css (0 hunks)
  • v3/internal/templates/vanilla-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/vanilla/frontend/public/style.css (0 hunks)
  • v3/internal/templates/vue-ts/frontend/public/style.css (0 hunks)
  • v3/internal/templates/vue/frontend/public/style.css (0 hunks)
💤 Files with no reviewable changes (18)
  • v3/examples/file-association/frontend/public/style.css
  • v3/internal/templates/lit-ts/frontend/src/my-element.ts
  • v3/internal/templates/preact/frontend/public/style.css
  • v3/internal/templates/svelte/frontend/public/style.css
  • v3/internal/templates/qwik-ts/frontend/public/style.css
  • v3/internal/templates/qwik/frontend/public/style.css
  • v3/internal/templates/vanilla/frontend/public/style.css
  • v3/internal/templates/lit/frontend/src/my-element.js
  • v3/internal/templates/svelte-ts/frontend/public/style.css
  • v3/internal/templates/vue-ts/frontend/public/style.css
  • v3/internal/templates/sveltekit-ts/frontend/static/style.css
  • v3/internal/templates/solid-ts/frontend/public/style.css
  • v3/internal/templates/vue/frontend/public/style.css
  • v3/internal/templates/preact-ts/frontend/public/style.css
  • v3/internal/templates/sveltekit/frontend/static/style.css
  • v3/internal/templates/sveltekit/frontend/frontend/style.css
  • v3/internal/templates/solid/frontend/public/style.css
  • v3/internal/templates/vanilla-ts/frontend/public/style.css
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Run Go Tests (ubuntu-latest, 1.23)
  • GitHub Check: Run Go Tests (macos-latest, 1.23)
  • GitHub Check: Run Go Tests (windows-latest, 1.23)
🔇 Additional comments (1)
docs/src/content/docs/changelog.mdx (1)

80-80: LGTM! The changelog entry is well-formatted and accurately describes the fix.

The entry follows the established format and correctly documents the fix for the footer visibility issue in light mode for non-React templates.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcus-crane marcus-crane changed the title [v3] [v3] Fix invisible footer under "light mode" across default templates Feb 10, 2025
@marcus-crane marcus-crane changed the title [v3] Fix invisible footer under "light mode" across default templates [v3] Fix invisible footer for light mode users across default templates Feb 10, 2025
@marcus-crane marcus-crane changed the base branch from master to v3-alpha February 10, 2025 02:53
@marcus-crane
Copy link
Contributor Author

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Feb 10, 2025

✅ Actions performed

Summary regeneration triggered.

@leaanthony
Copy link
Member

Thanks for this 🙏 Please could you add an entry to the changelog located at docs/src/content/docs/changelog.mdx? Thanks!

Signed-off-by: Marcus Crane <[email protected]>
@marcus-crane
Copy link
Contributor Author

Added a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants