-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LecturesOfTablePage 리팩토링 #421
Conversation
@@ -44,6 +44,7 @@ android { | |||
compileOptions { | |||
sourceCompatibility = JavaVersion.VERSION_17 | |||
targetCompatibility = JavaVersion.VERSION_17 | |||
isCoreLibraryDesugaringEnabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 쓰면 minSdk 안 올리고 java.time 쓸 수 있대
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그럼 이거 적용해서 Notification에서도 LocalDateTime 쓰게 고쳐봐야겠다
72e3018
to
5a4e910
Compare
b726cf6
to
b8ebcd9
Compare
@@ -26,7 +26,6 @@ allprojects { | |||
google() | |||
mavenCentral() | |||
maven(url = "https://jitpack.io") | |||
maven("https://naver.jfrog.io/artifactory/maven/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이걸 없애야 빌드가 된다는거지?? 뭐지...
확인해볼게 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠... 나는 없애도 잘 되고 안없애도 잘 되는것 같은데..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉진짜?? 빌드만하는 거 말고 실행할때 터짐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안없애고 실행도 잘 돼
clean build부터 실행까지 싹 해봤는데도 잘 돼.. ㅋㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 요거 전 회사에서 그랬는데
어떤 repository가 지원종료되고 그 repository에서만 받을 수 있는 라이브러리가 있을 때
지원종료 이전에 sync해둔 사람은 안스 라이브러리 캐시에 jar이 남아있어서 빌드 성공하고
지원종료 이후에 sync한 사람은 라이브러리 못 받아와서 빌드 실패하는
그런 일이 있었음
아마 이것도 그런 게 아닐까.....?
최대한 빠르게 검토해보겠습니다... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
살짝 봤는데 나는 괜찮은것 같아..! 아직 꼼꼼히 보지는 못했지만...
@Composable | ||
private fun TableLectureAddNew(modifier: Modifier, onClickAdd: () -> Unit) { | ||
Column( | ||
modifier = modifier.clicks { onClickAdd.invoke() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 onClickAdd()
안하고 onClickAdd.invoke()
한 이유가 있어?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뭐야이거
object PreviewData { | ||
val sampleSessions = listOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이것도 흥미롭네 notificatonPage 2차 리팩 할 때 참고해야겠다
override val registrationCount: Long, | ||
override val wasFull: Boolean, | ||
|
||
val reviewInfo: LectureReviewInfo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제보니 이거 SearchedLecture 가 아니라 LectureSyllabusInfo 에 있어야되네
다음PR에서 고치겠음ㅁ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셧습니다
PR description에 mermaid 짱이다
커밋별 안내
Lecture 관련
그때 결국 끝까지 결론을 못 했던 것 같은데, 이렇게 함 해봤고 필드 배치 틀린 거 있으면 제보부탁 ㅎㅎ