Add support for alt text for legend images

[pmacMaps]

I've added an alt property to the legend images. I'm using the label property.

I also added a second map service to the example that has label values set.

[w8r]

I

[w8r]

I don't like hard-coded English phrases in the template, it increases the accessibility, but affects the localisation, is there a way around it?

[pmacMaps]

I agree with this. Would adding an option that let's the user specify the text of the alt attribute be a reasonable solution?

Something like the following:

L.esri.Controls.legend([dynamicLayer, featureLayer], {
   position: 'topright',
   altTextTemplate: 'icon representing a map layer'
}).addTo(map);

I would still want to use the label property, but understand it could get tricky without knowing what the user would pass in?

Any thoughts or suggestions?

[w8r]

it's a good suggestion! But probably it would require a second pass to substitute? or it can be replaced where it's added.

    listRowTemplate: '<li><img alt="'+ altTextTemplate +'" width="{width}" height="{height}" src="data:{contentType};base64,{imageData}"><span>{label}</span></li>',

[w8r]

Thanks a lot for your PR, do you think we can fix the localisation issue there?

[pmacMaps]

I removed the English text in the alt attribute, and now only reference the label property from the map service. This still helps with web accessibility (assuming there is a label for the map layer).

I still think it would be cool to add a constructor option to set default alt text. I tried, but failed to figure it out. And anyway, it is your call if you would even want that.

Thanks for the feedback.

[w8r]

I suggested a way to pass the alt string template, do you want to add it? I can merge without it though, if you don't have time

[pmacMaps]

I did try something similar to what you proposed. But I kept getting jshint errors and the files wouldn't build.

I don't know when I'll be able to dig into this further, so I would be fine if you merge it as is.

[pmacMaps]

Did you want to merge it as is? Even though we want to add in the user-defined alt template text. This will at least provide a basic level of the alt attribute.