Fix AuthenticationExtensionsAuthenticatorInputs/Outputs CDDL #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the CDDL grammar, after a control operator (called `ctlop` in the ABNF grammar), there can only be a `type2` production: https://datatracker.ietf.org/doc/html/rfc8610#appendix-B In a `type2` production, wrapping parentheses can only be used to wrap a `type` production. `tstr => any` is a `group` production, and needs to be wrapped in curly braces or brackets. In other words, from a CDDL grammar perspective, this is an invalid type: `foo .within ( tstr => any )` This is valid: `foo .within { tstr => any }` This update fixes the CDDL type definitions that used the `.within` operator with an invalid type2.
|
Sorry, I hadn't realized that you had sent a pull request on my fork! GitHub's handling of notifications for personal repositories never ceases to amaze me... Anyway, this looks good to me, and feel free to ditch the initial PR I had prepared! |
selfissued
approved these changes
Dec 18, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 18, 2024
SHA: 57efac8 Reason: push, by selfissued Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the combination of PR #2219 and the changes proposed in tidoust#1 . Merging this PR would effectively merge #2219 as well, and means we don't need to wait for @tidoust to review tidoust#1.
The issue is similar to the "proposed change 1" of #2210. I recently had clarified on the CDDL mail list that control operators only apply to types, not groups. @tidoust's PR #2219 fixes the right-hand side, but not the left-hand side. This PR completes the fix.
Preview | Diff