Make remaining USVStrings DOMStrings
#2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you!
I double-checked that this won't be a backwards compatibility trap, and concluded that:
evalByCredentialfurther restricts the permitted character set to just the Base64Url alphabet, so it is not possible for aDOMStringvalue to be a validevalByCredentialkey but not a validUSVString.- For FIDO AppID we refer to the FIDO AppID and Facet Specification, and the reference chain ultimately leads to section 4.2 of RFC 5891 and a table in RFC 5892 which lists
D800..FA0D ; DISALLOWED # <Non Private Use High Surrogate>..CJK COMPAT.USVStringis defined as a string containing no code points in the range U+D800 to U+DFFF, inclusive. Thus it is not possible for aDOMStringvalue to be a valid FIDO AppID but not a validUSVString.
So this change seems safe to me.
timcappalli
approved these changes
Dec 18, 2024
agl
approved these changes
Dec 18, 2024
akshayku
approved these changes
Dec 18, 2024
pascoej
approved these changes
Dec 18, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 18, 2024
SHA: 26e28ec Reason: push, by selfissued Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2203.
Preview | Diff