Delete authenticatorDisplayName #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this go back into the credProps extension text? At this time, one [=credential property=] is defined: the [=resident key credential property=]
(i.e., [=client-side discoverable credential property=]).I don't feel strongly either way. |
timcappalli
approved these changes
Nov 13, 2024
|
Good point! With that I also noticed that there was some more un-reverted stuff related to extending the extension to authentication ceremonies, so I reverted that too. |
akshayku
approved these changes
Nov 13, 2024
MasterKale
approved these changes
Nov 13, 2024
pascoej
approved these changes
Nov 13, 2024
emlun
deleted the
issue-2187-drop-credentialRecord-authenticatorDisplayName
branch
github-actions bot
added a commit
that referenced
this pull request
Nov 13, 2024
…thenticatorDisplayName SHA: fd53e2c Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2187.
The following tasks have been completed:
Implementation commitment: N/A
Documentation and checks: N/A
Preview | Diff