Skip to content

Test "modified" for notes that have been adapted to the WCAG2ICT context #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test "modified" for notes that have been adapted to the WCAG2ICT context #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
670e818
Test "modified" for notes that have been adapted to the WCAG2ICCT con…
daniel-montalvo Jun 20, 2025
fcd4fd1
Add what "ADDED" and "MODIFIED" mean in the document conventions section
maryjom Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comments-by-guideline-and-success-criterion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ With this substitution, it would read:

**4.1.2 Name, Role, Value:** For all [user interface components](#dfn-user-interface-components) (including but not limited to: form elements, links and components generated by scripts), the [name](#dfn-name) and [role](#dfn-role) can be [programmatically determined](#dfn-programmatically-determinable); [states](https://www.w3.org/TR/WCAG22/#dfn-states), properties, and values that can be set by the user can be [programmatically set](#dfn-programmatically-set); and notification of changes to these items is available to [user agents](#user-agent), including [assistive technologies](#dfn-assistive-technologies).

<div class="note">
<div class="note modified">

This success criterion is primarily for software developers who develop or use custom user interface components. Standard user interface components on most [accessibility-supported](#dfn-accessibility-supported) platforms already meet this success criterion when used according to specification.</div>
<div class="note wcag2ict">
Expand Down
1 change: 1 addition & 0 deletions introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ The following stylistic conventions are used in this document:
* Additional guidance provided by this document begins with the phrase “Applying” and has no special visual styling.
* Replacement text that is presented to show how an SC would read as modified by the advice in this document are in `<ins>` elements visually styled as bold green text with a dotted underline.
* Notes are slightly inset and begin with the phrase “NOTE”. Each note is in its own inset box styled in pale green with a darker green line on the left side of the box.
* Where WCAG Notes have been replaced or partially rewritten in the guidance, they are notated with "(MODIFIED)". Where WCAG2ICT added new notes, they are notated with "(ADDED)".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that all the "replaced" would become "modified" now? To me there is nuance around these two: "replaced" being completely rewritten whereas "modified" being slightly reworded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a little nuanced. With this note, we kept the spirit of the original note, but it was a little more than simple word replacements. Maybe we should simply use "replaced" and provide the replacement note in the description of the word replacements like we did in the other cases where a note was rewritten/replaced. Sounds like a good topic for the leader or editor call this week.

* References to glossary items from WCAG 2 are presented in `<cite>` elements visually styled as ordinary text with a dotted underline, and contain title attributes noting these are WCAG definitions. They turn blue with a yellow background when mouse or keyboard focus is placed over them.
* References to glossary items in this document are presented in `<cite>` elements visually styled as ordinary text with a dark gray underline.
* Hereafter, the short title “WCAG2ICT” is used to reference this document.
Expand Down
3 changes: 3 additions & 0 deletions wcag2ict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ function furtherProcessNotesAndExamples() {
if (note.querySelector(".replacement")) {
noteTitle = noteTitle + " (Replaced)";
}
if (note.querySelector(".modified")) {
noteTitle = noteTitle + " (Modified)";
}
if (note.querySelector(".original")) {
noteTitle = noteTitle + " (Original)";
}
Expand Down