Added validation examples. #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this is good to add. I would additionally link to the validation spec draft that would be used/followed for each example.
One thing I think we should do to make this easier to view is having a tabbed example viewer like this https://www.w3.org/TR/vc-data-model/#example-usage-of-the-type-property, you can see the respec code for it here https://github.com/w3c/vc-data-model/blob/main/REC/2022-03-03/index.html#L2525
|
Also I would say #143 would not be fully addressed until we show examples with at least data integrity and having it packaged as a JWT |
|
@decentralgabe PTAL, should have addressed all the feedback. |
decentralgabe
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to address #143 for VC claimsets (i.e. a VC without the proof piece being referenced.
Preview | Diff