Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localConfig instructions. #46

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Conversation

aljones15
Copy link
Contributor

No description provided.

@aljones15 aljones15 self-assigned this May 30, 2024
@aljones15 aljones15 marked this pull request as ready for review May 30, 2024 22:27
@aljones15 aljones15 requested review from BigBlueHat and tminard May 31, 2024 13:12
package.json Outdated
@@ -9,7 +9,7 @@
},
"scripts": {
"test": "mocha tests/ --reporter @digitalbazaar/mocha-w3c-interop-reporter --reporter-options abstract=\"$PWD/config/abstract.hbs\",reportDir=\"$PWD/reports\",respec=\"$PWD/config/respec.json\",suiteLog='./suite.log',templateData=\"$PWD/reports/index.json\",title=\"Data Integrity eddsa 2022 Interoperability Report 1.0\" --timeout 15000 --preserve-symlinks",
"lint": "eslint ."
"lint": "eslint --ext .js,.cjs ."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an eslint config file? These can go there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this kind of surprised me, but actually I don't think there is a config file way of specifying the file extensions, but there is an eslint config file way of specifying the file glob patterns so I used that here: 40e0733

Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiddly code formatting tweak request.

README.md Outdated Show resolved Hide resolved
@BigBlueHat BigBlueHat self-requested a review June 3, 2024 18:38
@aljones15 aljones15 merged commit 8a8a4f5 into main Jun 3, 2024
2 checks passed
@aljones15 aljones15 deleted the change-to-localConfig-example branch June 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants