Clarify that TTL is optional and doesn't override validity. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
added
normative
msporny
requested review from
BigBlueHat,
dlongley,
jandrieu,
longpd,
iherman,
TallTed,
brianorwhatever,
decentralgabe,
KDean-Dolphin,
brentzundel and
PatStLouis
TallTed
approved these changes
Nov 25, 2024
PatStLouis
approved these changes
Dec 2, 2024
dlongley
approved these changes
Dec 2, 2024
longpd
approved these changes
Dec 2, 2024
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #174 by clarifying that TTL is optional and doesn't override the credential's validity period.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Nov 24, 2024, 11:22 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.