Skip to content

Expand Syntax Tests of Decimal Numbers in Turtle #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Conversation

tobiaswjohn
Copy link
Contributor

Addresses the issue raised in #193 by adding two test inputs for the syntax of decimal numbers in Turtle.

As suggested, I put the syntax tests into the RDF 1.2 folder, although the syntax are already part of RDF 1.1.

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests themselves are fine, but as they're testing 1.1 behavior and not 1.2 behavior, I think they should be in the rdf11/rdf-turtle manifest. Generally, tests in rdf12/ are for new behavior or syntax expected with features introduced in RDF 1.2.

@afs
Copy link
Contributor

afs commented Jun 24, 2025

The tests themselves are fine, but as they're testing 1.1 behavior and not 1.2 behavior, I think they should be in the rdf11/rdf-turtle manifest. Generally, tests in rdf12/ are for new behavior or syntax expected with features introduced in RDF 1.2.

Can we accept the PR then reorganise?

Copy link
Contributor

@Tpt Tpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Greg but happy to see it in a follow up

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a follow up to reorganize.

@gkellogg gkellogg merged commit ddf77e0 into w3c:main Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants