fix up definitions for non-ground graphs #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afs
reviewed
Apr 17, 2025
TallTed
reviewed
Apr 17, 2025
spec/index.html
Outdated
Comment on lines
503
to
509
| <li> [I+A](x)=I(x) when x is a <a>name</a>; </li> | ||
| <li> [I+A](x)=A(x) when x is a blank node; </li> | ||
| <li> [I+A](x)= RE( [I+A](x.s), [I+A](x.p), [I+A](x.o) ) when x is a triple term, where x.s, x.p, and x.o are the first, second, and third components of x, respectively; </li> | ||
| <li> [I+A](x)=true when x is a triple and [I+A](p) is in IP and the pair <[I+A](s),[I+A](o)> is in IEXT([I+A](p)); | ||
| <li> [I+A](x)=false when x is a triple, otherwise; | ||
| <li> [I+A](x)=false if x is an RDF graph and [I+A](x')=false for some triple x' in x; | ||
| <li> [I+A](x)=true if x an RDF graph, otherwise |
There was a problem hiding this comment.
-
Why do some conditional phrases use
whenand others useif?It seems to me that consistent phrasing should be used throughout this list, and throughout similar lists elsewhere in this document.
-
Why do some (multiple!) list items end with
otherwise, sometimes followed by;and sometimes not?It seems to me that each item in this unordered list should be disjoint from all other items in this list, and that the join of all items should encompass all possible conditions. I would not use
otherwiseat all, and I suggest ending each list item with a full stop (.), not ever a semicolon (;) nor other punctuation.
Co-authored-by: Andy Seaborne <[email protected]>
Co-authored-by: Andy Seaborne <[email protected]>
pfps
added
the
spec:enhancement
afs
approved these changes
May 1, 2025
TallTed
reviewed
May 2, 2025
Comment on lines
+508
to
+509
| <li> [I+A](x)=false if x is an RDF graph and [I+A](x')=false for some triple x' in x;</li> | ||
| <li> [I+A](x)=true if x an RDF graph, otherwise</li> |
There was a problem hiding this comment.
Suggested change
| <li> [I+A](x)=false if x is an RDF graph and [I+A](x')=false for some triple x' in x;</li> | |
| <li> [I+A](x)=true if x an RDF graph, otherwise</li> | |
| <li> [I+A](x)=false if x is an RDF graph and [I+A](x')=false for some triple x' in x;</li> | |
| <li> [I+A](x)=true if x an RDF graph, otherwise</li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Preview | Diff