Skip to content

Suggestions from January review on §1.2 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Apr 23, 2025

Bob DuCharme's 7th comment
https://www.w3.org/mid/[email protected]

Bob notes that the comma makes it look like we are introducing a new idea
@pchampin pchampin added spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial labels Apr 23, 2025
@pchampin pchampin requested review from gkellogg, afs and hartig April 23, 2025 23:36
Copy link
Contributor

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change proposal.

spec/index.html Outdated
Comment on lines 187 to 188
to an RDF triple is known as an <dfn data-local-lt="statement">RDF statement</dfn>.
(As we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to an RDF triple is known as an <dfn data-local-lt="statement">RDF statement</dfn>.
(As we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted.)
to an RDF triple is known as an <dfn data-local-lt="statement">RDF statement</dfn>
(as we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have written it that way too, but Bob did put the whole sentence in the parenthesis.
@afs? @gkellogg? What's your take on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to make sense to me, whether or not the current parenthetical is put before or after the full-stop of the preceding sentence, there must be an indication that the "basic" or "default" triple is asserted. I do think it reads better as @bobdc put it. I would also add <dfn data-local-lt="asserted"> which I did not include below.

So, perhaps, like this:

Suggested change
to an RDF triple is known as an <dfn data-local-lt="statement">RDF statement</dfn>.
(As we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted.)
to an RDF triple is known as an <dfn data-local-lt="statement">RDF statement</dfn>, and sometimes as an asserted triple.
(As we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted.)

Copy link
Contributor Author

@pchampin pchampin Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, @bobdc suggested to put the parenthesis after the 1st sentence of the paragraph, which starts with "Asserting and RDF triple...".

I though the flow of the whole paragraph was better with the parenthetical after the 2nd sentence, but I can see now that it was not as good. Will revert to the original suggestion (but applying @hartig's suggestion for the punctuation).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use "As we shall see ..." .
The document does not use "we" in the text except at "We informally use the term RDF source ..." which is acceptable.

"Not all triples are asserted." is enough IMO.

@pchampin pchampin requested a review from TallTed April 25, 2025 06:38
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with it.

@pfps
Copy link
Contributor

pfps commented May 22, 2025

Isn't this simply editorial?

strings in a natural language including an initial text direction.</p>

<p>Asserting an <a>RDF triple</a> says that <em>some relationship,
indicated by the <a>predicate</a>, holds between the
<a>resources</a> <a>denoted</a> by
the <a>subject</a> and <a>object</a></em>. This statement corresponding
the <a>subject</a> and <a>object</a></em>
(as we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(as we shall see <a href="#section-triple-terms-reification">below</a>, not all triples are asserted).
(as explained <a href="#section-triple-terms-reification">below</a>, not all triples are asserted).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afs how about this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants