Conversation
gkellogg
left a comment
There was a problem hiding this comment.
I’m a bit concerned about saying that special rules without listing other important schemes, as this will lead to interoperability issues.
Which schemes did you have in mind? I picked HTTP (important) and DID (W3C) for the note. URNs are complicated (there are rules per namespace).
Some schemes don't exist! |
those certainly make sense given the context, but we make a broad statement that could include obscure schemes, or those yet to be released. White-listing specific schemes (http, https, and did, roof example) would enhance interoperability. |
Is the note text enough?
I have changed it to "HTTP/HTTPS" An advice paragraph somewhere to use specific schemes might be nice (but outside this PR). Aside: ReSpec has not used the more usual RFC reference -- https://datatracker.ietf.org/doc/html/rfc7230. |
|
I think @gkellogg 's concern could be addressed in the note, by rephrasing it:
|
|
I think @pchampin’s suggested wording is okay. The SHOULD makes testing a bit challenging, though. Typically, we do not test SHOULD/MAY behavior. |
|
Note updated. If they don't recognize a scheme, it isn't an option to ignore - they must! For the testing, my ideal is having "SHOULD" is there because (1) this is new, not in RDF 1.1 (2) the "rules" aren't always cut-and-dried. |
|
I will squash the PR to one commit before merge; for now, the PR is keeping each change as a commit. |
|
@pchampin This is waiting on your approval. The duplicated text has been fixed. |
This closes #135.
This PR is close to the changes in #131 and #132 and will probably need adjusting after they are merged.
Preview | Diff