-
Notifications
You must be signed in to change notification settings - Fork 229
add did:swtc method #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add did:swtc method #648
Conversation
|
Hello @GinMu , Good day. After an initial review, I have some feedback: DID Method Structure Samples here:
CRUD Operations Your CRUD operations should be described in at least a few bullets. Providing code is fine, but there should be human readable explanations of the CRUD methods that you support (ideally an algorithm describing the steps): Samples here:
Security and Privacy Considerations section
Suggest you address these points and then we can review again. Thank you. |
|
@ottomorac Thanks for the review! I applied the suggested change and pushed a new commit. Please take another look when you have a moment. |
ottomorac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GinMu . The entry meets the minimum criteria, Approved. You will need one additional review from others in the group before this can be merged.
|
Also I might suggest that you indicate that the DELETE operation is not supported in your spec (at least that was my understanding from reading it). |
The DELETE method is not currently supported. You can achieve deletion by writing empty data (i.e., overwriting the item with an empty payload). |
Understood. 👍 Then perhaps you may want to add that explanation in the spec for the did:swtc DID method. |
I’ve already added that explanation to the spec for the did:swtc DID method. 🤝 |
|
I agree that the submission meets the minimum requirements for approval, but I do have a few suggestions and comments about the spec.
Happy to approve with or without answers to those questions/comments. |
Instructions for Pull Requests
Please read these instructions thoroughly in order to ensure that your pull request is processed in a timely manner. This document contains detailed instructions for registering a DID Method. If your pull request concerns some other change to the repository, you may delete all of the text in this text box and write up a more relevant description.
There is a DID Method Registration form below that MUST be included in a DID Method Registration Request. The form includes check boxes that you are expected to fill out when you submit your request.
Once you submit your request, your pull request will be reviewed by the registry editors. Changes regarding the required criteria may be requested. If there are no objections or changes requested, your DID method will be registered after a minimum of 7 days.
DID Method Registration Process
In order to register a new DID method, you must add a JSON file to the ./methods directory.
Here is an example registration entry:
{ // These fields are required "name": "example", "status": "registered", "specification": "https://w3c-ccg.github.io/did-spec/", // These fields are optional "contactName": "W3C Credentials Community Group", "contactEmail": "", "contactWebsite": "", "verifiableDataRegistry": "DID Specification" }Your Pull Request will be automatically validated, please ensure that all of the automated tests pass (no errors reported) or your submission will not be reviewed. Common reasons for failed validation includes invalidly formatted JSON files and missing mandatory fields.
----- DID METHOD REGISTRATION FORM: DELETE EVERYTHING ABOVE THIS LINE ------
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmailaddress [OPTIONAL].verifiableDataRegistryentry [OPTIONAL].