[css-mixins-1] Check default values against the parameter type #12243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoublev
approved these changes
May 28, 2025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2025
The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 11, 2025
The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2025
The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2025
The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jun 23, 2025
…eir type, a=testonly Automatic update from web-platform-tests [functions] Validate defaults against their type The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448} -- wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b wpt-pr: 53072
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 23, 2025
…eir type, a=testonly Automatic update from web-platform-tests [functions] Validate defaults against their type The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448} -- wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b wpt-pr: 53072
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 24, 2025
…eir type, a=testonly Automatic update from web-platform-tests [functions] Validate defaults against their type The spec was recently clarified to make @function rules with "mistyped" defaults invalid. For example, the following is now invalid, because the default given for --arg doesn't match the type given for --arg: @function --foo(--arg <color>: 10px) { /* ... */ } w3c/csswg-drafts#12243 Fixed: 423673310 Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1472448} -- wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b wpt-pr: 53072
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 24, 2025
…eir type, a=testonly
Automatic update from web-platform-tests
[functions] Validate defaults against their type
The spec was recently clarified to make function rules
with "mistyped" defaults invalid. For example, the following
is now invalid, because the default given for --arg doesn't match
the type given for --arg:
function --foo(--arg <color>: 10px) { /* ... */ }
w3c/csswg-drafts#12243
Fixed: 423673310
Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858
Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Steinar H Gunderson <sessechromium.org>
Cr-Commit-Position: refs/heads/main{#1472448}
--
wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b
wpt-pr: 53072
UltraBlame original commit: cc226a2da0cb6c607e660d2caf650f8930115318
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 24, 2025
…eir type, a=testonly
Automatic update from web-platform-tests
[functions] Validate defaults against their type
The spec was recently clarified to make function rules
with "mistyped" defaults invalid. For example, the following
is now invalid, because the default given for --arg doesn't match
the type given for --arg:
function --foo(--arg <color>: 10px) { /* ... */ }
w3c/csswg-drafts#12243
Fixed: 423673310
Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858
Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Steinar H Gunderson <sessechromium.org>
Cr-Commit-Position: refs/heads/main{#1472448}
--
wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b
wpt-pr: 53072
UltraBlame original commit: cc226a2da0cb6c607e660d2caf650f8930115318
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 24, 2025
…eir type, a=testonly
Automatic update from web-platform-tests
[functions] Validate defaults against their type
The spec was recently clarified to make function rules
with "mistyped" defaults invalid. For example, the following
is now invalid, because the default given for --arg doesn't match
the type given for --arg:
function --foo(--arg <color>: 10px) { /* ... */ }
w3c/csswg-drafts#12243
Fixed: 423673310
Change-Id: I3239b573ece22bb48746a496758d53f57ac00b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632858
Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Steinar H Gunderson <sessechromium.org>
Cr-Commit-Position: refs/heads/main{#1472448}
--
wpt-commits: 779425e137ff128ba9736c9e8cb3812cd9fac95b
wpt-pr: 53072
UltraBlame original commit: cc226a2da0cb6c607e660d2caf650f8930115318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11922