Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ephemeral-daifuku-0dc7d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
hey @daniel-montalvo, can you explain what part isn't working? Seems like everything is passing here. Is that because it is not landed? How have you been testing, btw? @jnurthen or I can try to take a look once we have a bit more context |
Thanks. I think this is not even running on this PR because there's no core-aam directory, thus there's not been any changes to the core-aam/ directory. I was getting stuck at the download artifact step, but I think something like https://github.com/daniel-montalvo/aria/actions/runs/9299954322/ should work. This is under my own forks that I set up earlier for testing. It's still failing because it does not have enough permission on the daniel-montalvo/core-aam repo, but this is something I think I can fix by creating specific tokens for each of the specs. @spectranaut @jnurthen @pkra Does this sound like a path forward to replicate with the other specs? |
daniel-montalvo
changed the title
|
@spectranaut @pkra @jnurthen Have you had a chance to review this? If this sounds OK to you I can then replicate the action for the rest of the specs. I think having an action per spec is best because we optimize the runs based on the paths, and avoid having unnecessary runs. |
|
@daniel-montalvo I'm not sure what kind of review comments make sense. Since it will only trigger on push to main, there's no test run to review, right? I don't know the artifact actions too well but it looks ok to me. |
|
Thanks.
For now, I was only looking to see if that’s an approach that makes sense for you all. This is tricky to test, and I think we won’t really be able to test it until we merge.
Next steps for me are to replicate all the actions needed per spec and to add the steps for it to be able to publish on TR space.
…--
Daniel Montalvo Charameli
Accessibility Specialist
W3C/WAI
From: Peter Krautzberger ***@***.***>
Sent: Wednesday, June 5, 2024 12:35 PM
To: w3c/aria ***@***.***>
Cc: Daniel Montalvo ***@***.***>; Mention ***@***.***>
Subject: Re: [w3c/aria] [Monorepo] Editors-draft-actions (PR #2227)
@daniel-montalvo <https://github.com/daniel-montalvo> I'm not sure what kind of review comments make sense. Since it will only trigger on push to main, there's no test run to review, right? I don't know the artifact actions too well but it looks ok to me.
—
Reply to this email directly, view it on GitHub <#2227 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALYFOWQDRMTKXE47FTZESETZF3SVJAVCNFSM6AAAAABINSBCFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBZGQ3DAMRYGU> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
spectranaut
left a comment
spectranaut
left a comment
There was a problem hiding this comment.
thanks for this!! one question about the common directory -- see comments in line. otherwise I think this looks good, and maybe we need to land to test
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: accname | ||
| path: accname |
There was a problem hiding this comment.
do we need common directory here as well?
There was a problem hiding this comment.
What I am aiming for here is trust the spec-prod action to pick up all it needs from common. To see detailed steps on how this action runs, you can see https://github.com/w3c/accname/actions/runs/9424164070/job/25963922169#step:3:531 especially where it copies the relevant assets. It then details which assets it's copying and then it uploads them as an artifact together with the generated HTML snapshot.
3 participants
No description provided.