Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Issue504 description list roles (#951)" #2095

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Revert "Issue504 description list roles (#951)" #2095

merged 1 commit into from
Jan 5, 2024

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jan 3, 2024 •
edited by pr-preview bot
Loading

This reverts commit b371203.

Preview | Diff

@cookiecrook cookiecrook mentioned this pull request Jan 4, 2024
Merged
@jnurthen
Copy link
Member Author

jnurthen commented Jan 4, 2024

Make sure to fix changelog when that gets merged

scottaohara
scottaohara approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending comment about fixing changelog that mentions the addition of these roles

@cookiecrook
Copy link
Contributor

approved pending comment about fixing changelog that mentions the addition of these roles

That will be handled (deleted and not re-added to the new log) by f393ca2 in #2096

So I think this one is good to go.

@jnurthen jnurthen merged commit 86a5d23 into main Jan 5, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Jan 5, 2024
@jnurthen @github-actions
Revert "Issue504 description list roles (#951)" (#2095)
1f2fbf0 
SHA: 86a5d23
Reason: push, by jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
YusukeHirao pushed a commit to YusukeHirao/markuplint that referenced this pull request Jan 21, 2024
Remove associationlist, associationlistitemkey, and `associationl…
f5c639f 
…istitemvalue` roles.

Rel: w3c/aria#2095
YusukeHirao pushed a commit to YusukeHirao/markuplint that referenced this pull request Jan 21, 2024
Remove associationlist, associationlistitemkey, and `associationl…
0716d3d 
…istitemvalue` roles.

Rel: w3c/aria#2095
@pkra pkra mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes

@pkra pkra pkra approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jnurthen @cookiecrook @pkra @scottaohara