The unprefixed Fullscreen API has been finally enabled on some browsers#202
Open
maverick42 wants to merge 1 commit intovvvmax:masterfrom
Open
The unprefixed Fullscreen API has been finally enabled on some browsers#202maverick42 wants to merge 1 commit intovvvmax:masterfrom
maverick42 wants to merge 1 commit intovvvmax:masterfrom
Conversation
…Firefox and Chrome. So events are no longer triggered because the detection was not done in the right order. Tested with success on : PC/Opera 57.0.3098.106 PC/Chrome 71.0.3578.98 PC/Chromium 71.0.3578.98 PC/Firefox 64.0 PC/IE 11.0.9600.19230 Ipad/Safari 12.1 Ipad/Firefox 14.0 Imac/Safari 12.2.0.2 Imac/Firefox 64.0 Android 8.1/Chrome 71.0.3578.99
Owner
|
Thanks a lot! Ill check your function and add to the gallery.
…On Sun, Dec 30, 2018, 6:35 PM Frédérik BENOIST ***@***.*** wrote:
The unprefixed Fullscreen API has been finally enabled by default on
Firefox and Chrome. So events are no longer executed because the detection
was not done in the correct order.
https://www.fxsitecompat.com/en-CA/docs/2018/fullscreen-api-has-been-unprefixed/
------------------------------
You can view, comment on, or merge this pull request online at:
#202
Commit Summary
- The unprefixed Fullscreen API has been finally enabled by default on
Firefox and Chrome. So events are no longer triggered because the detection
was not done in the right order.
File Changes
- *M* source/unitegallery/js/ug-functions.js
<https://github.com/vvvmax/unitegallery/pull/202/files#diff-0> (18)
Patch Links:
- https://github.com/vvvmax/unitegallery/pull/202.patch
- https://github.com/vvvmax/unitegallery/pull/202.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#202>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC_K_s5PgyHVFtHzqfx8qzDkeewx1QzBks5u-OtugaJpZM4Zk_sW>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unprefixed Fullscreen API has been finally enabled by default on Firefox and Chrome. So events are no longer executed because the detection was not done in the correct order.
https://www.fxsitecompat.com/en-CA/docs/2018/fullscreen-api-has-been-unprefixed/