Skip to content

Fix jquery 3.10 compatiblity#102

Open
mhamri wants to merge 2 commits intovvvmax:masterfrom
mhamri:fix-jquery-3.10-compatiblity
Open

Fix jquery 3.10 compatiblity#102
mhamri wants to merge 2 commits intovvvmax:masterfrom
mhamri:fix-jquery-3.10-compatiblity

Conversation

@mhamri
Copy link
Copy Markdown

@mhamri mhamri commented Aug 19, 2016

in jquery 3.10 instead of .load(funcName) we need to use .on("load", funcName). I've tested unite gallery with tiles theme and it worked fine.

please note that I used visual studio to edit the repo, the minified version really minified to one line and .gitignore modified. i forgot to unstage them, please ignore them

@vvvmax
Copy link
Copy Markdown
Owner

vvvmax commented Aug 22, 2016

ok, thanks. I'll check this issue soon and update the gallery.

On Fri, Aug 19, 2016 at 11:12 AM, Mohammad Hossein Amri <
notifications@github.com> wrote:

in jquery 3.10 instead of .load(funcName) we need to use .on("load",

funcName). I've tested unite gallery with tiles theme and it worked fine

You can view, comment on, or merge this pull request online at:

#102
Commit Summary

  • fix a bug that make it incompatible with jquery 3.10
  • fix jquery 3.10 bug

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#102, or mute the thread
https://github.com/notifications/unsubscribe-auth/AC_K_qcsWxxs0K9u1LVekaAh_fXbcLv-ks5qhWV4gaJpZM4JoPr7
.

@vvvmax
Copy link
Copy Markdown
Owner

vvvmax commented Oct 29, 2016

thanks. fixed the issue. will update the version soon. no need to merge.

On Mon, Aug 22, 2016 at 5:13 PM, maxim vendrov vvvmax@gmail.com wrote:

ok, thanks. I'll check this issue soon and update the gallery.

On Fri, Aug 19, 2016 at 11:12 AM, Mohammad Hossein Amri <
notifications@github.com> wrote:

in jquery 3.10 instead of .load(funcName) we need to use .on("load",

funcName). I've tested unite gallery with tiles theme and it worked fine

You can view, comment on, or merge this pull request online at:

#102
Commit Summary

  • fix a bug that make it incompatible with jquery 3.10
  • fix jquery 3.10 bug

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#102, or mute the thread
https://github.com/notifications/unsubscribe-auth/AC_K_qcsWxxs0K9u1LVekaAh_fXbcLv-ks5qhWV4gaJpZM4JoPr7
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants