Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): improve MotionPlugin types #231

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

cjboy76
Copy link
Contributor

@cjboy76 cjboy76 commented Sep 6, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Enables autocomplete for MotionPlugin options.

To ensure compatibility, please check that the Vue version in the root codebase matches the Vue version used in the playground/vite before testing.

ζˆͺεœ– 2024-09-05 15 26 47

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@vueuse/motion@231

commit: 85a3b9b

Copy link
Collaborator

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@BobbieGoede BobbieGoede changed the title types: improve MotionPlugin autocomplete fix(types): improve MotionPlugin types Sep 6, 2024
@BobbieGoede BobbieGoede merged commit f6983db into vueuse:main Sep 6, 2024
8 checks passed
@cjboy76 cjboy76 deleted the types/autocomplete branch September 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants