Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use toRaw when cloning proxy object #221

Merged

Conversation

hajiskyy
Copy link
Contributor

πŸ”— Linked issue

Nuxt 3 error with custom directive #218

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #218

This changes ensure that the custom directive object are not Vue's reactive object to allow the StructuredClone function to as expected.

Perhaps this should have always been included?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede
Copy link
Collaborator

Thanks for contributing! Could you rebase/update your branch with main? It would allow us to publish a preview release now with #220 merged, that way we can easily check if this fix works in a reproduction.

@hajiskyy
Copy link
Contributor Author

@BobbieGoede Thanks for the feedback! I've confirmed that my branch is already up to date with the latest main branch. Please let me know if there's anything else I should check.

@BobbieGoede BobbieGoede force-pushed the fix/nuxt-3-error-with-custom-directives branch from ba05dce to 5d9eab8 Compare August 28, 2024 12:02
Copy link

pkg-pr-new bot commented Aug 28, 2024

commit: 5d9eab8

pnpm add https://pkg.pr.new/@vueuse/motion@221

Open in Stackblitz

Copy link
Collaborator

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed this resolves the issue in #218

@BobbieGoede BobbieGoede changed the title fix: nuxt-3-error-with-custom-directives fix: use toRaw when cloning proxy object Aug 28, 2024
@BobbieGoede BobbieGoede merged commit 47ad58d into vueuse:main Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3 Error with custom directives
2 participants