feat(VCommandPalette): add new component #21459
Draft
+20,863
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update types for CommandCorePublicAPI interface
update Playground and ScenarioContextMenu for improved accessibility and error handling. Adjust VBtn command execution logic for better state management. Enhance VCommandPalette tests and component structure for robustness and clarity.
- Added hotkey options for save actions in ScenarioContextualActions.vue to prevent default behavior and stop propagation. - Updated undo action hotkey to support both 'cmd' and 'ctrl' in ScenarioUndoRedo.vue. - Refined logic for handling input blockers in action core to accommodate various runInTextInput scenarios. - Expanded test cases in actionCore.spec.ts to validate new hotkey configurations and ensure correct behavior across multiple action definitions.
- Introduced ShowSubItemsUISymbol for global sub-items UI handling, allowing components to display sub-items of actions. - Registered the new settings action with a global hotkey in ScenarioActionWithSubItems.vue, ensuring consistent hotkey behavior. - Updated ActionCore to initialize key bindings with capture: true for improved event handling. - Enhanced VHotKey component to support display modes for hotkeys, improving accessibility and user experience. - Added tests to validate the new hotkey configurations and ShowSubItemsUI integration in actionCore.spec.ts and useKeyBindings.spec.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces two new components. VCommandPalette and VHotKey.
It also introduces a global, reactive data store for registering actions that will be displayed and listed in the command palette.
Markup:
There is a comprehensive playground for you to try out. It's point is not to be beautiful, it is to demonstrate functionality.
https://github.com/vuetifyjs/vuetify/blob/feat%2FActionCore-VCommandPalette/packages%2Fvuetify%2Fplaygrounds%2FPlayground.actionCore.vue
Documentation here: https://github.com/vuetifyjs/vuetify/tree/feat%2FActionCore-VCommandPalette/packages%2Fvuetify%2Fsrc%2Flabs%2FVActionCore%2Fdocumentation