Skip to content

chore: un-deprecate firstDayOfWeek #21454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

J-Sek
Copy link
Contributor

@J-Sek J-Sek commented May 21, 2025

Looking a this after a while.. users sometimes get a dropdown to change week start - overriding their locale preferences. It is a valid scenario and I don't see any way to achieve this with VLocaleProvider

@J-Sek J-Sek self-assigned this Jun 2, 2025
@J-Sek J-Sek requested a review from johnleider June 12, 2025 13:59
@johnleider johnleider requested a review from a team June 12, 2025 20:40
@johnleider
Copy link
Member

What does all of this look like in the precursor to Temporal taking over date stuff? Are we able to do this in a way that regardless of what adapter the developer uses, it will work?

@J-Sek
Copy link
Contributor Author

J-Sek commented Jun 12, 2025

What does all of this look like in the precursor to Temporal taking over date stuff? Are we able to do this in a way that regardless of what adapter the developer uses, it will work?

Option 1: Keep disclaimers about "no guarantee" to work with custom adapters and rely on developers to extend the adapter class (we have a minimal guide in the docs, but we could add more with copy-pastable snippets).

Option 2: Introduce a proxy around the adapter so we can detect non-empty firstDayOfWeek argument and redirect method calls to our internal implementation.

@johnleider
Copy link
Member

I like Option 2 as long as it can be a small code footprint and require zero changes from the user.

@J-Sek
Copy link
Contributor Author

J-Sek commented Jun 17, 2025

roduce a proxy around the adapter so we can detect non-empty firstDayOfWeek argument and redirect method calls to our internal implementation.

Do you need a PoC before we merge this PR?

@J-Sek J-Sek merged commit de95deb into vuetifyjs:dev Jun 18, 2025
10 checks passed
@J-Sek J-Sek deleted the fix/undeprecate-first-day-of-week branch June 18, 2025 07:48
@KaelWD KaelWD added this to the v3.9.0 (Zealot) milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants