fix the sidebar title of beyond the current window that it follows the title of the article in the current window #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the title of the sidebar exceeds the current window, it does not automatically follow the document title to display in the current window. See my blog post for the effect, try sliding your mouse: https://zpj80231.github.io/znote/views/java/ThreadLocal.html
zpj80231
changed the title
haoranpb
reviewed
Apr 12, 2020
There was a problem hiding this comment.
Nice catch! But I think you may want to move your changes to @vuepress/plugin-active-header-links
And there are some unexpected behaviors I found. Try to visit deploy-preview, the document won't scroll to the correct position. And when scroll to the bottom of Config Reference, the sidebar do scroll with the content, but try to scroll back to the top.
zpj80231
commented
Apr 15, 2020
There was a problem hiding this comment.
Fixed several issues:
- Fix full path jump to correct navigation and page.
- When the sidebar title is not in the current window, the sidebar title automatically scrolls down with the content.
- When the sidebar title is not in the current window, the sidebar title automatically scrolls up with the content
Try to visit https://zpj80231.gitee.io/znote/views/java/ThreadLocal.html#简介.
I tried to move the change to @vuepress/plugin-active-header-links, but found it didn't work.
zpj80231
commented
Apr 17, 2020
|
@ludanxer I think all problems have been solved, please visit the latest deploy-preview. |
|
good!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the title of the sidebar exceeds the current window, it does not automatically follow the document title to display in the current window.
See my blog post for the effect, try sliding your mouse: https://zpj80231.github.io/znote/views/java/ThreadLocal.html
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: