Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the wrong orders of call 'detached' and 'destroyed' hook - #3870 #4888

Open
wants to merge 1 commit into
base: 1.1
Choose a base branch
from

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Feb 9, 2017

@Kingwl
Copy link
Member Author

Kingwl commented Feb 9, 2017

btw
my eslint does not seem to work

/vue/src/compiler/compile.js
  8:1  error  '../util/index' import is duplicated  no-duplicate-imports

/vue/src/global-api.js
  19:1  error  './util/index' import is duplicated  no-duplicate-imports

/vue/test/unit/specs/parsers/expression_spec.js
  181:17  error  Unnecessary escape character: \'  no-useless-escape
  181:20  error  Unnecessary escape character: \'  no-useless-escape

but i never mod those file

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

my eslint does not seem to work

eslint that installed in your enviroments is too latest.
eslint of vue 1.x is based 2.x.
https://github.com/vuejs/vue/blob/1.1/package.json#L55

You should be checked eslint in your environments. 😉

@Kingwl
Copy link
Member Author

Kingwl commented Feb 10, 2017

@kazupon thanks XD

@yyx990803 yyx990803 added the 1.x label Feb 14, 2017
@MrMitch
Copy link

MrMitch commented Jan 26, 2018

Hi,

Was this ever merged ?

@yyx990803 yyx990803 removed the 1.x label Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants