fix: changed a type for AsyncComponentFactory component(fix #10252)#10253
Open
NataliaTepluhina wants to merge 2 commits intovuejs:devfrom
Open
fix: changed a type for AsyncComponentFactory component(fix #10252)#10253NataliaTepluhina wants to merge 2 commits intovuejs:devfrom
NataliaTepluhina wants to merge 2 commits intovuejs:devfrom
Conversation
posva
requested changes
Jul 10, 2019
Member
posva
left a comment
posva
left a comment
There was a problem hiding this comment.
Can you add a test case for this?
It would be nice to also include in the commit body a reference to the issue Close #10252
NataliaTepluhina
force-pushed
the
fix-async-component-type
branch
from
a4f9d12 to
f75a39d
Compare
Member
Author
|
@posva added a test as requested 😅 |
posva
approved these changes
Jul 14, 2019
posva
reviewed
Jan 6, 2020
|
|
||
| export type AsyncComponentFactory<Data=DefaultData<never>, Methods=DefaultMethods<never>, Computed=DefaultComputed, Props=DefaultProps> = () => { | ||
| component: AsyncComponentPromise<Data, Methods, Computed, Props>; | ||
| component: Promise<Component | EsModuleComponent>; |
Member
There was a problem hiding this comment.
as @pikax noted, Data, Methods,... are not used anymore. Maybe we should pass them to Component
|
I've just spent a couple of hours trying to figure out what was wrong with my code and it turns out this was the problem... Any special reason this PR has not been merged yet? If by any chance the author isn't available anymore, is there any way I could take over this issue? |
Erthbgjvffbjg
approved these changes
Jul 21, 2021
|
000201 |
dev-benguo
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Close #10252