Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): add validation when initializing VitePress configuration #3640

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

0xlau
Copy link
Contributor

@0xlau 0xlau commented Mar 7, 2024

close #3641

If the configuration directory of VitePress is outside the project root directory, the project will not run correctly, so add this validation logic to ensure that the path entered by the user is within the root directory.

p1

@0xlau 0xlau changed the title feat(build): add validation when initializing VitePress configuration feat(init): add validation when initializing VitePress configuration Mar 7, 2024
@0xlau
Copy link
Contributor Author

0xlau commented Apr 30, 2024

@brc-dd 😂 I forgot to checkout the new branch to submit this pr. Do I need to close this pr and resubmit a new one with the new branch instead of 0xlau/main branch.

@brc-dd
Copy link
Member

brc-dd commented Apr 30, 2024

Nah it's fine. Don't close it.

@github-actions github-actions bot added the stale label Jun 9, 2024
@github-actions github-actions bot removed the stale label Jul 17, 2024
@github-actions github-actions bot added the stale label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add validation when initializing VitePress configuration
2 participants