Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve async issues with language tools loading #275

Closed

Conversation

sunnylost
Copy link

fix #263

Because reloadLanguageTools() is an asynchronous method, it may be called repeatedly before disposeVue is created, leading to volar.registerProviders() not being correctly disposed of, resulting in duplicate hover cards.

Copy link

vercel bot commented Aug 24, 2024

@sunnylost is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 6:29am

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: ea7a055

pnpm add https://pkg.pr.new/vuejs/repl/@vue/repl@275

Open in Stackblitz

@sxzz sxzz closed this in f9f650a Aug 27, 2024
@sunnylost sunnylost deleted the fix/correctly-dispose-volar-service branch August 27, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[monaco]: duplicate hover tooltips
1 participant