-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): move to esm-only #2947
base: v3
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pinia-official canceled.
|
according to the nuxt module-builder docs:
but we don't reference that file anymore after this change. maybe that's why the export had a separate |
Moves to an esm-only package now that all LTS other than 18.x (which is soon to fall out of LTS) support `require(esm)`.
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2947 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 17 17
Lines 1398 1398
Branches 211 211
=======================================
Hits 1277 1277
Misses 120 120
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@danielroe do you know when nuxt-builder alpha is planned to become stable? wondering if we should use the alpha tag for now or just wait |
you should be safe to already use the alpha tag here - the only niggle is for modules that include Vue components in their |
Moves to an esm-only package now that all LTS other than 18.x (which is soon to fall out of LTS) support
require(esm)
.This is a draft until nuxt/module-builder 1.x becomes non-alpha
1.x outputs esm only, whereas 0.x outputs cjs too.