Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vue 2 tests #3674

Merged
merged 14 commits into from
Oct 23, 2023
Merged

chore: update vue 2 tests #3674

merged 14 commits into from
Oct 23, 2023

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Oct 17, 2023

fixes vuejs/vue#13104, based on #3351

Actually this is a vue 2.7 type issue: it doesn't convert emits to props. However vue 2.7 seemed to be unmaintained, I fix it in language-tools. Also improves JSX compactibility

@so1ve so1ve marked this pull request as draft October 17, 2023 06:46
@rchl
Copy link
Collaborator

rchl commented Oct 17, 2023

I'm looking at the changes and I don't quite see how it's related to #3351. Maybe it does handle the "emits" case but I don't see how it would handle class, style, etc.

@so1ve
Copy link
Member Author

so1ve commented Oct 17, 2023

@rchl I mean I added vue 2.7 tests in this pr 👀

@so1ve so1ve changed the title fix: wip fix: convert emits to props Oct 17, 2023
@so1ve so1ve marked this pull request as ready for review October 17, 2023 08:54
@so1ve
Copy link
Member Author

so1ve commented Oct 17, 2023

I suggest merge #3351 first, @rchl's work should be respected! 🫡

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Oct 23, 2023

Thanks for investigating this, but I think we should avoid bypassing the problem in language tools, otherwise vue repo will never fix it, and fixing upstream problems also out of repo scope.

@so1ve
Copy link
Member Author

so1ve commented Oct 23, 2023

Thanks, I'll rewrite this PR to contain some vue2-related test changes.

@so1ve so1ve changed the title fix: convert emits to props chore: update vue 2 tests Oct 23, 2023
@johnsoncodehk johnsoncodehk merged commit 5f2c029 into vuejs:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 2.7 strictTemplates error
3 participants