Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compat): allow v-model built in modifiers on component #12654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(compat): allow v-model built in modifiers on component #12654

wants to merge 3 commits into from
+68 −2

Conversation

markrian
Copy link

@markrian markrian commented Jan 6, 2025 •
edited by edison1105
Loading

close #12652
This is a rough attempt at fixing #12652.

@markrian
fix(compat): allow v-model built in modifiers on component

Verified

This commit was signed with the committer’s verified signature. The key has expired.
goto-bus-stop Renée
GPG key ID: 8CDD5F0BC448F040
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
dd4f72d 
close vuejs#12652
@markrian markrian mentioned this pull request Jan 6, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+6 B) 37.9 kB (-2 B) 34.2 kB (-18 B)
vue.global.prod.js 158 kB (+6 B) 57.8 kB (-1 B) 51.5 kB (+80 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.3 kB (+6 B) 18.2 kB (+2 B) 16.6 kB (+5 B)
createApp 54.2 kB (+6 B) 21.1 kB (+2 B) 19.4 kB (+71 B)
createSSRApp 58.4 kB (+6 B) 22.9 kB (+1 B) 20.9 kB (+71 B)
defineCustomElement 59.1 kB (+6 B) 22.7 kB (+1 B) 20.7 kB (-8 B)
overall 68.3 kB (+6 B) 26.3 kB (+2 B) 23.9 kB (+47 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 7, 2025 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12654

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12654

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12654

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12654

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12654

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12654

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12654

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12654

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12654

vue

npm i https://pkg.pr.new/vue@12654

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12654

commit: 9d1a0b2

@markrian
chore: simplify

Verified

This commit was signed with the committer’s verified signature. The key has expired.
goto-bus-stop Renée
GPG key ID: 8CDD5F0BC448F040
Expired
Verified
Learn about vigilant mode
e2dc92d
@markrian
chore: simplify more

Verified

This commit was signed with the committer’s verified signature. The key has expired.
goto-bus-stop Renée
GPG key ID: 8CDD5F0BC448F040
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
9d1a0b2 
`compatModelEventPrefix + event in props` can only be true if
`isCompatEnabled(DeprecationTypes.COMPONENT_V_MODEL, instance)`; see
`convertLegacyVModelProps`.
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: v2 compat 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. and removed wait changes labels Jan 7, 2025
@edison1105
Copy link
Member

edison1105 commented Jan 7, 2025 •
edited
Loading

@markrian
LGTM~ Thank you for resolving the issue you raised.

@miguelrincon
Copy link

@edison1105 pinging you because it looks like this could be merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: v2 compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compat: v-model modifiers do not work on components
3 participants
@markrian @edison1105 @miguelrincon