Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traduction de cookbook/packaging-sfc-for-npm #230

Merged
merged 28 commits into from
Dec 23, 2020
Merged

Traduction de cookbook/packaging-sfc-for-npm #230

merged 28 commits into from
Dec 23, 2020

Conversation

glomepe
Copy link

@glomepe glomepe commented Nov 16, 2020

No description provided.

@MachinisteWeb MachinisteWeb self-assigned this Nov 16, 2020
MachinisteWeb
MachinisteWeb reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@MachinisteWeb MachinisteWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci infiniment @iamgpe !

Quelque remarques.

src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
Kocal
Kocal reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques remarques, merci pour la contribution ! :)

src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
glomepe and others added 13 commits November 17, 2020 01:54
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
27c39ce 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe
Update packaging-sfc-for-npm.md
d6b0cf9
@glomepe
Update packaging-sfc-for-npm.md
f464d7c 
#230 (comment)
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
20a31d9 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
170f73b 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
12b72d8 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
ff66e7c 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
b9abe08 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe @Kocal
Update src/v2/cookbook/packaging-sfc-for-npm.md
18024dc 
Co-authored-by: Hugo Alliaume <[email protected]>
@glomepe
Update packaging-sfc-for-npm.md
8ffb234 
#230 (comment)
#230 (comment)
#230 (comment)
#230 (comment)
#230 (comment)
@glomepe
Update packaging-sfc-for-npm.md
839b392 
#230 (comment)
#230 (comment)
@glomepe
Replacing word for improve readability
c151da7 
#230 (comment)
@glomepe
Improve readability
1f4bfd1 
#230 (comment)
@glomepe glomepe changed the title French translation of packaging-sfc-for-npm.md Improved readability Nov 17, 2020
@glomepe glomepe changed the title Improved readability Traduction de cookbook/packaging-sfc-for-npm Nov 17, 2020
forresst
forresst reviewed Nov 17, 2020
View reviewed changes
Copy link

@forresst forresst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques propositions/corrections

Très beau travail

src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
forresst
forresst approved these changes Nov 17, 2020
View reviewed changes
Copy link

@forresst forresst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ok pour mes remarques

darenju
darenju reviewed Nov 17, 2020
View reviewed changes
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
src/v2/cookbook/packaging-sfc-for-npm.md Outdated Show resolved Hide resolved
Kocal
Kocal approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 🚀

@MachinisteWeb MachinisteWeb merged commit 6d31b09 into vuejs-fr:master Dec 23, 2020
@MachinisteWeb MachinisteWeb mentioned this pull request Oct 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MachinisteWeb MachinisteWeb MachinisteWeb left review comments

@darenju darenju darenju left review comments

@Kocal Kocal Kocal approved these changes

@forresst forresst forresst approved these changes

@mdartic mdartic Awaiting requested review from mdartic

Assignees

@MachinisteWeb MachinisteWeb

Labels
Relecture nécessaire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glomepe @forresst @darenju @Kocal @MachinisteWeb