Repository navigation
Shorten search key lifetime and trim indexed fields - #746
Merged
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 443 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: vusa-frontend-esmAssets Changed:
Files in
Files in
Files in
|
justinaskav
force-pushed
the
fix/search-keys
branch
from
November 6, 2026 20:38
84eb898 to
360be35
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Written by Codex.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
justinaskav
force-pushed
the
fix/search-keys
branch
from
November 6, 2026 20:50
360be35 to
38ac38b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search key lifetime, logout and indexed fields.
activity_statusis excluded from search results for users without global institution read; the UI drops that facet/filter for them. (A client filter on the field is still possible; full separation would need a separate index.)Who made what: Codex wrote the change and tests; Claude reviewed it, fixed one fixture, and ran the tests.
Check by hand: a collection page left open past 15 minutes keeps searching; both logout flows; institution list as a baseline user and as a global admin.
Deploy: reindex users (
search:reindexor the users collection) so hidden pronouns drop out. Rotating the admin parent search key afterwards (typesense:rotate-keys --delete-old) retires previously issued keys.🤖 Generated with Claude Code