Repository navigation
Narrow upload types and keep request attachments private - #744
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
justinaskav
force-pushed
the
fix/uploads
branch
from
November 6, 2026 20:38
7e164b1 to
3f4c0c9
Compare
Bundle ReportChanges will increase total bundle size by 647 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: vusa-frontend-esmAssets Changed:
Files in
|
…ge details Written by Codex.
justinaskav
force-pushed
the
fix/uploads
branch
from
November 6, 2026 20:50
3f4c0c9 to
004deab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploads, support request attachments and file usage details.
public/.htaccess(and the local nginx template) sendnosniffon/uploads/and a sandbox policy for HTML/SVG/XML files there.supportRequests.evidence, authorised against the request.Who made what: Codex wrote the change and tests; Claude reviewed it, sent back broken test fixtures, and ran the tests.
Check by hand: uploading a PDF/PNG still works and an SVG is refused with a clear message; support request screenshots load for the submitter and handlers; the file usage list with hidden references.
Deploy:
/uploadsheaders on production. FastPanel's nginx may serve static files without reaching.htaccess; PDFs and images must not get the sandbox header.php artisan media:privatize-evidence --sync, then check--status. Public copies remain until--cleanupis run deliberately (it lists the files and asks first).🤖 Generated with Claude Code