This repository was archived by the owner on Oct 26, 2022. It is now read-only.
Fix diffphot docstring #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We subtract the magnitude of the comparison star from that of the star, not the other way around: https://github.com/vterron/lemon/blob/0a33c725bf2f229d9ae9e3f9de50bfb2141a3fba/diffphot.py#L468
akdiaz
approved these changes
Apr 9, 2021
Comment on lines
+44
to
+45
| (2) A decreasing differental magnitude in the light curve means that our | ||
| star appears brighter. |
Collaborator
There was a problem hiding this comment.
I would put it the other way around because is usually what happens in reality (e.g. transit):
An increasing differential magnitude in the light curve means that our star becomes fainter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We subtract the magnitude of the comparison star from that of the star, not the other way around, see:
lemon/diffphot.py
Line 468 in 0a33c72