Skip to content

Commit

Permalink
ci/GHA: fix wolfSSL-from-source AES-GCM tests
Browse files Browse the repository at this point in the history
Turns out these tests:

31 - [email protected] (Failed)
36 - [email protected] (Failed)

were failing because AES-GCM wasn't enabled in libssh2. This in turn
happened because the `WOLFSSL_AESGCM_STREAM` macro wasn't enabled while
building wolfSSL. Which happened because this macro isn't enabled by
any CMake-level wolfSSL option. Passing it as `CPPFLAGS` fixes it.

This allows enabling tests with wolfSSL 5.7.0.

Follow-up to d4cea53 libssh2#1408
Closes libssh2#1409
  • Loading branch information
vszakats committed Jun 21, 2024
1 parent d4cea53 commit 2b43abf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
-DWOLFSSL_OPENSSLALL=ON \
-DWOLFSSL_EXAMPLES=OFF \
-DWOLFSSL_CRYPT_TESTS=OFF \
-DCMAKE_C_FLAGS=-fPIC \
'-DCMAKE_C_FLAGS=-fPIC -DWOLFSSL_AESGCM_STREAM' \
"-DCMAKE_INSTALL_PREFIX=$PWD/../usr"
make -j5 -C bld install
cd ..
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
if: ${{ matrix.build == 'cmake' }}
run: cmake --build bld --parallel 5 --target package
- name: 'cmake tests'
if: ${{ matrix.build == 'cmake' && matrix.crypto != 'wolfSSL' && matrix.crypto != 'wolfSSL-from-source' }}
if: ${{ matrix.build == 'cmake' && matrix.crypto != 'wolfSSL' }}
timeout-minutes: 10
run: |
export OPENSSH_SERVER_IMAGE=ghcr.io/libssh2/ci_tests_openssh_server:$(git rev-parse --short=20 HEAD:tests/openssh_server)
Expand Down

0 comments on commit 2b43abf

Please sign in to comment.