feat: add AntV diagrams + Leaflet maps#83
Open
OchnikBartek wants to merge 3 commits into
Open
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
DEENUU1
reviewed
Jun 3, 2026
DEENUU1
left a comment
Member
There was a problem hiding this comment.
Solid, well-documented feature — the per-framework MCP wiring, graceful degradation, typed MapMarker schema, and the dedicated content tests are all nicely done. A few things worth addressing before merge: a doc/compose mismatch around the production compose, publishing the unauthenticated MCP port to the host in prod, and two edge cases in the tool-discovery memoization (thread-safety race + permanent caching of a transient failure). Inline comments below.
…fety - antv_chart.py: guard tool discovery with a module-level lock (CrewAI + LangChain loaders) so requests racing in the FastAPI threadpool can't each start an adapter; memoize only on success so a transient sidecar failure (e.g. still warming up) is retried instead of caching [] and pinning AntV off until the process restarts. - docker-compose.yml (prod): drop the host port mapping for the antvis-chart sidecar — the backend reaches it over the internal network; publishing 1122 exposed an unauthenticated MCP/render endpoint. - docker-compose.dev.yml: keep the host port, documented as dev-only. - VARIABLES.md: correct the claim that the sidecar isn't in the prod compose — it is, just profile-gated and off by default. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
aiohttp 3.13.5 has CVE-2026-34993 and CVE-2026-47265 (fixed in 3.14.0). pyjwt 2.12.1 has PYSEC-2026-175/177/178/179 (fixed in 2.13.0). Both are transitive deps pulled in via the project venv; bumping them unblocks the Security Scan CI job and re-enables all template test jobs that were skipping because they need: [security]. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AntV diagram sidecar + Leaflet map rendering to the generated template, with reliability fixes for MCP tooling across all 6 AI frameworks.
Changes
enable_antv_chartscookiecutter variable gating AntV MCP sidecar, diagram tools, and Leaflet map renderingcreate_maptool withMapMarkertyped schema — prevents empty-marker validation errors from weaker models (GPT-4.5 etc.)create_mapinto all 6 framework assistants with typed signatures for JSON schema fidelityget_antv_crewai_toolsmemoizes the started adapter so it's started once per process, not once per request_run_synconly blocks on first requestwgetrejected by streamable-HTTP endpoint → replaced withnodeone-linerMapSpec._validate_center(matches per-marker validation)parse_map_specexportreact-leafletmap renderer in frontend (MapMessage,MapLeafletcomponents)tool-call-card.tsxpydantic_ai,langchain,crewaiwithenable_antv_chartsandenable_chartsTestGeneratedTemplateAntvChartscontent tests verifying typed markers, bounds check, cache variables, and absence of removed dead codeTesting
--antv-charts; all render, compile, pass ruffTestGeneratedTemplateAntvChartscontent tests:MapMarkerpresent, bounds check present,parse_map_specabsent,list[MapMarker]in assistant, module-level cache in antv_chart.pymake testmake lintmake typecheck