Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify needs_rebalance function #14

Merged
merged 1 commit into from
Sep 18, 2024
Merged

simplify needs_rebalance function #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,7 @@ async fn handle_get_record(
}

let replicas_volumes = record::get_volume(&key, volumes, replicas, subvolumes);
let needs_rebalance_header = if needs_rebalance(&key, &replicas_volumes, record.read_volumes())
{
let needs_rebalance_header = if needs_rebalance(&replicas_volumes, record.read_volumes()) {
"unbalanced"
} else {
"balanced"
Expand Down Expand Up @@ -408,20 +407,8 @@ async fn handle_get_record(
};
}

fn needs_rebalance(key: &str, replicas_volumes: &[String], record_read_volumes: &[String]) -> bool {
if replicas_volumes.len() != record_read_volumes.len() {
error!("get_record: key: {} needs rebalance", key);
return true;
}

for i in 0..replicas_volumes.len() {
if replicas_volumes[i] != record_read_volumes[i] {
error!("get_record: key: {} needs rebalance", key);
return true;
}
}

false
fn needs_rebalance(replicas_volumes: &[String], record_read_volumes: &[String]) -> bool {
replicas_volumes.len() != record_read_volumes.len()
}

async fn remote_head(client: &reqwest::Client, remote_url: &str) -> anyhow::Result<()> {
Expand Down
Loading