feat: require rubocop 1.91 - #229
Merged
Merged
Conversation
rubocop-performance 1.27.0 requires rubocop >= 1.89.0, so the current ~> 1.85.1 pin makes it impossible to install alongside voxpupuli-test. rubocop-rake 0.7.1 and rubocop-rspec 3.9.0 already support 1.91. The shared rubocop.yml sets `NewCops: enable`, so this turns on the cops added in 1.86-1.91 (Lint/ArgumentMismatch, Lint/DeprecatedReference, Lint/MisplacedMagicComment, Lint/NameTypo, Lint/SuperArgumentMismatch, Style/DirectiveScope, Style/TimeNow) and Lint/CopDirectiveSyntax, which is now enabled by default. Consumers may see new offenses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
kenyon
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubocop-performance 1.27.0 requires rubocop >= 1.89.0, so the current ~> 1.85.1 pin makes it impossible to install alongside voxpupuli-test. rubocop-rake 0.7.1 and rubocop-rspec 3.9.0 already support 1.91.
The shared rubocop.yml sets
NewCops: enable, so this turns on the cops added in 1.86-1.91 (Lint/ArgumentMismatch, Lint/DeprecatedReference, Lint/MisplacedMagicComment, Lint/NameTypo, Lint/SuperArgumentMismatch, Style/DirectiveScope, Style/TimeNow) and Lint/CopDirectiveSyntax, which is now enabled by default. Consumers may see new offenses.Generated by Claude Code