Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: patch prometheus::daemon to support custom extract directories #606

Closed
kubicgruenfeld opened this issue Feb 28, 2022 · 0 comments · Fixed by #834
Closed

TODO: patch prometheus::daemon to support custom extract directories #606

kubicgruenfeld opened this issue Feb 28, 2022 · 0 comments · Fixed by #834
Assignees
@TheMeier

Comments

@kubicgruenfeld
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: all
  • Ruby: all
  • Distribution: all
  • Module version: latest

How to reproduce (e.g Puppet code you use)

See https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/redis_exporter.pp#L105 and
https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/postgres_exporter.pp#L129

What are you seeing

# TODO: patch prometheus::daemon to support custom extract directories

What behaviour did you expect instead

prometheus::daemon supports a custom extract directory.

Output log

Any additional information you'd like to impart

This issue is just a reminder that there is an open TODO.
@kubicgruenfeld kubicgruenfeld mentioned this issue Feb 28, 2022
Merged
@TheMeier TheMeier mentioned this issue Dec 30, 2024
Closed
@TheMeier TheMeier self-assigned this Dec 31, 2024
TheMeier added a commit that referenced this issue Dec 31, 2024
@TheMeier
remove custom use of archive for several exporters
37a5fbf 
some exporters have different layout of the release archives, for these
workarounds where in place to handle the different layouts. All theses cases
are now implemented using the options that prometheus::daemon provides.

fixes #606
TheMeier added a commit that referenced this issue Dec 31, 2024
@TheMeier
remove custom use of archive for several exporters
1c09fc7 
some exporters have a layout of the release archives that does not fit the
assumptions in prometheus::daemon. For these exporters
workarounds where in place to handle the different layouts. All theses cases
are now implemented using the options that prometheus::daemon provides.

fixes #606
@TheMeier TheMeier mentioned this issue Dec 31, 2024
Merged
TheMeier added a commit that referenced this issue Dec 31, 2024
@TheMeier
remove custom use of archive for several exporters
8e1e183 
some exporters have a layout of the release archives that does not fit the
assumptions in prometheus::daemon. For these exporters
workarounds where in place to handle the different layouts. All theses cases
are now implemented using the options that prometheus::daemon provides.

fixes #606
TheMeier added a commit that referenced this issue Dec 31, 2024
@TheMeier
Merge pull request #834 from /issues/606
838ca6e 
remove custom use of archive for several exporters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheMeier TheMeier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove custom use of archive for several exporters voxpupuli/puppet-prometheus
2 participants
@kubicgruenfeld @TheMeier