rabbit_mq exporter cannot be download for versions > 1.0.0-RC8

[stevegreengvl]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7
• Ruby:
• Distribution:
• Module version: 2.23.0

How to reproduce (e.g Puppet code you use)

prometheus::rabbitmq_exporter::version: '1.0.0-RC19'

What are you seeing

Download Failed

What behaviour did you expect instead

Download success

Output log

https://github.com/kbudde/rabbitmq_exporter/releases/download/v1.0.0-RC19/rabbitmq_exporter-1.0.0-RC19.linux-amd64.tar.gz
Not Found

Any additional information you'd like to impart

Correct URI would be
https://github.com/kbudde/rabbitmq_exporter/releases/download/v1.0.0-RC19/rabbitmq_exporter-1.0.0-RC19_linux-amd64.tar.gz

[jeee-naut]

If you use puppet code

prometheus::rabbitmq_exporter::version: '1.0.0-RC19' 
prometheus::rabbitmq_exporter::download_url: 
 https://github.com/kbudde/rabbitmq_exporter/releases/download/v1.0.0-RC19/rabbitmq_exporter_1.0.0-RC19_linux_amd64.tar.gz'

the download succeeds but the file does not extract to the intended location.
It extracts to /opt instead of /opt/rabbitmq_exporter-1.0.0-RC19.linux-amd64/

The created symlink /usr/local/bin/rabbitmq_exporter
which is what systemd uses to start the service, points into this directory

Notice: /Stage[main]/Prometheus::Rabbitmq_exporter/Prometheus::Daemon[rabbitmq_exporter]/Archive[/tmp/rabbitmq_exporter-1.0.0-RC19.tar.gz]/ensure: download archive from https://github.com/kbudde/rabbitmq_exporter/releases/download/v1.0.0-RC19/rabbitmq_exporter_1.0.0-RC19_linux_amd64.tar.gz to /tmp/rabbitmq_exporter-1.0.0-RC19.tar.gz and extracted in /opt with cleanup (corrective)

Interesting is the notice of the second puppet run
Notice: /Stage[main]/Prometheus::Rabbitmq_exporter/Prometheus::Daemon[rabbitmq_exporter]/Archive[/tmp/rabbitmq_exporter-1.0.0-RC19.tar.gz]/creates: creates changed 'archive not extracted' to extracting in /opt to create /opt/rabbitmq_exporter-1.0.0-RC19.linux-amd64/rabbitmq_exporter (corrective)

But it doesn't do what is claimed. The directory /opt/rabbitmq_exporter-1.0.0-RC19.linux-amd64/ still does not exist.

[TheMeier]

This is similar to #606. prometheus::deamon expects a specific that exporter releases have a specific top-level dir in the tgz, which the pre 1.x releases have the releases >= 1.0.0 don't have it