-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easyrsa version range #452
Open
jan-win1993
wants to merge
6
commits into
voxpupuli:master
Choose a base branch
from
markt-de:easyrsa-version-range
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-win1993
force-pushed
the
easyrsa-version-range
branch
from
January 8, 2024 17:25
45bb117
to
7f5a17e
Compare
@bastelfreak Could we get a review please? Thanks :) |
bastelfreak
reviewed
Jun 25, 2024
Comment on lines
+146
to
+151
if versioncmp($openvpn::easyrsa_version, '4') == -1 { | ||
if versioncmp($openvpn::easyrsa_version, '3.0.3') == 1 { | ||
$default_easyrsa_openssl_conf = 'openssl-easyrsa.cnf' | ||
} else { | ||
$default_easyrsa_openssl_conf = 'openssl-1.0.cnf' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if versioncmp($openvpn::easyrsa_version, '4') == -1 { | |
if versioncmp($openvpn::easyrsa_version, '3.0.3') == 1 { | |
$default_easyrsa_openssl_conf = 'openssl-easyrsa.cnf' | |
} else { | |
$default_easyrsa_openssl_conf = 'openssl-1.0.cnf' | |
} | |
if versioncmp($openvpn::easyrsa_version, '4') == -1 { | |
$default_easyrsa_openssl_conf = if versioncmp($openvpn::easyrsa_version, '3.0.3') == 1 { | |
'openssl-easyrsa.cnf' | |
} else { | |
'openssl-1.0.cnf' | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request addresses 3 problems:
The following is a link to the corresponding commit:
OpenVPN/easy-rsa@e8cd6c9.
To tackle that problem I would like to introduce easy-rsa version ranges and change the file name if a version above 3.0.3 is used.