Feature/support all uri schemas in checksum url #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdmr
force-pushed
the
feature/support-all-uri-schemas-in-checksum-url
branch
4 times, most recently
from
ff48ed5 to
6ddca46
Compare
jvdmr
force-pushed
the
feature/support-all-uri-schemas-in-checksum-url
branch
from
6ddca46 to
66772b6
Compare
TomRitserveldt
approved these changes
May 19, 2025
|
@jvdmr thanks for the PR! Can you please rebase it against our latest master branch, to get rid of the merge commit? |
jvdmr
force-pushed
the
feature/support-all-uri-schemas-in-checksum-url
branch
from
62e9021 to
7517a3b
Compare
|
@bastelfreak absolutely, done! |
added 5 commits
June 23, 2025 19:00
…ompatible url parameter
jvdmr
force-pushed
the
feature/support-all-uri-schemas-in-checksum-url
branch
from
7517a3b to
590a5fe
Compare
jvdmr
force-pushed
the
feature/support-all-uri-schemas-in-checksum-url
branch
from
590a5fe to
8d2179a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
These changes allow the
checksum_urlparameter to use the same URI schemes available to thesourceparameter.Also adding and extending relevant unit tests, and updating documentation.
This PR also contains the validation code first proposed in #472
This Pull Request (PR) fixes the following issues
Fixes #339
Fixes #471