Skip to content

fix(triage): ignore archived twins in duplication scoring - #639

Merged
plind-junior merged 4 commits into
vouchdev:testfrom
kurosawareiji7007-hub:fix/triage-archived-dup-pool
Jul 30, 2026
Merged

fix(triage): ignore archived twins in duplication scoring#639
plind-junior merged 4 commits into
vouchdev:testfrom
kurosawareiji7007-hub:fix/triage-archived-dup-pool

Conversation

@kurosawareiji7007-hub

Copy link
Copy Markdown
Contributor

Summary

  • Triage duplication (and contradiction) pools treated archived/superseded/redacted claims and archived pages as live twins.
  • Re-filing the same text after archive got duplication_risk=1.0 and an advisory reject.
  • Pools, embedding claim hits, and contradiction partners now skip retracted claims; page-title pool skips ARCHIVED pages (same live-set as search/recall/digest).

Test plan

  • tests/test_triage.py::test_duplication_risk_ignores_archived_claim_twin
  • tests/test_triage.py::test_duplication_risk_ignores_archived_page_title
  • full tests/test_triage.py green
  • CI green on test

Fixes #638

@github-actions github-actions Bot added docs documentation, specs, examples, and repo guidance tests tests and fixtures size: S 50-199 changed non-doc lines labels Jul 30, 2026
claim and page pools used every approved artifact, so an archived claim
(or archived page title) with the same text forced duplication_risk=1.0
and an advisory reject on re-file. pools, embedding hits, and contradiction
partners now skip retracted claims and archived pages.

Fixes vouchdev#638
exercise _live_embedding_hits missing-id path, _topical_fit_scores
retracted claim/page skips, and contradiction skip for archived hits
so the 100% changed-line gate on vouchdev#639 can pass.
@kurosawareiji7007-hub
kurosawareiji7007-hub force-pushed the fix/triage-archived-dup-pool branch from 6979755 to 32bf4c0 Compare July 30, 2026 13:57
plind-junior and others added 2 commits July 30, 2026 11:23
Merge of test into vouchdev#639 left two test_build_excludes_archived_followups
defs (ruff F811), which failed CI lint before pytest ran.
@github-actions github-actions Bot added size: M 200-499 changed non-doc lines and removed size: S 50-199 changed non-doc lines labels Jul 30, 2026
@plind-junior

Copy link
Copy Markdown
Member

While this premise is not universally applicable, I intended to implement an automatic rejection protocol for claims that are identical or substantially similar to those previously archived or suspended but this time, I'm gonna follow your suggestion.

@plind-junior
plind-junior merged commit ec0cd95 into vouchdev:test Jul 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation, specs, examples, and repo guidance size: M 200-499 changed non-doc lines tests tests and fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants