ci(coderabbit): drop the coderabbit approval gate - #629
Merged
Conversation
coderabbit's verdict no longer gates or reaps anything. removed: - coderabbit-gate.yml, which published the `coderabbit-approved` commit status and auto-closed a pr after 3 rounds of requested changes. - stale-pr-reaper.yml, the daily sweep that closed prs sitting on an unaddressed change request. - the pr_bot commands behind both (`coderabbit-gate`, `stale-check`) and the verdict/strike/staleness helpers they called, plus their tests. the status had already been dropped from the test ruleset's required checks, which require five: the three test legs, the build, and trust-gate. so this removes machinery that outlived the requirement rather than lowering a bar that was still load-bearing. coderabbit still reviews every non-draft pr and still files formal approve / request-changes reviews — they are advisory now. the merge path is ci + trust-gate + codeowners, with the owner's auto-merge label as the go signal.
github-actions
Bot
added
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coderabbit's verdict no longer gates or reaps anything.
removed:
coderabbit-gate.yml— published thecoderabbit-approvedcommit statusand auto-closed a pr after 3 rounds of requested changes.
stale-pr-reaper.yml— the daily sweep that closed prs sitting on anunaddressed change request.
coderabbit-gate,stale-check) and theverdict / strike / staleness helpers they called, plus their tests.
worth knowing before reviewing: the
coderabbit-approvedstatus had alreadybeen dropped from the
testruleset's required checks, which now require five— the three test legs,
build sdist + wheel, andtrust-gate. so this takesout machinery that outlived the requirement rather than lowering a bar that was
still load-bearing. what it does end is the enforcement side: the 3-strike close
and the 2-day reaper were still live.
coderabbit still reviews every non-draft pr and still files formal approve /
request-changes reviews — they are advisory now.
.coderabbit.yamlkeepsrequest_changes_workflow: trueso its stance stays legible at a glance.the merge path is ci + trust-gate + codeowners, with the owner's auto-merge
label as the go signal.
full suite, ruff and mypy pass locally.
trust-gatewill fail on this pr forthe usual reason —
.github/**is a core path and the author is MEMBER, notOWNER — so it needs your review to land.