Skip to content

ci: patch the Vercel CLI's vulnerable dependencies - #11000

Merged
connortsui20 merged 1 commit into
developfrom
wm/vercel-cli-overrides
Oct 29, 2026
Merged

connortsui20 merged 1 commit into
developfrom
wm/vercel-cli-overrides

Conversation

@lwwmanning

Copy link
Copy Markdown
Contributor

This PR clears the 51 Dependabot alerts on .github/vercel-cli/package-lock.json. npm audit goes from 33 advisories to 0.

vercel@64.0.2 pins vulnerable versions of tar, undici, js-yaml, minimatch, path-to-regexp, smol-toml, ajv and zod. One tar advisory is critical. undici has a TLS validation bypass, and the deploy token goes through undici. vercel@65.0.0 pins the same versions.

npm overrides set each library to a fixed release past the 7-day cooldown. Only undici 5 changes major, to 6.29.1.

I made a real preview deploy with the patched CLI and the workflow flags. It worked.

🤖 Generated with Claude Code

vercel@64.0.2 pins tar, undici, js-yaml, minimatch, path-to-regexp,
smol-toml, ajv and zod at versions with 33 known advisories, including a
critical one in tar and a TLS certificate validation bypass in undici,
the HTTP client that carries the deploy token. vercel@65.0.0 pins the
same versions, so an upgrade does not help.

npm overrides in .github/vercel-cli now move each library to a fixed
release that is past the 7-day cooldown. All but undici 5 stay on their
major version. undici 5 moves to 6.29.1, which also drops
@fastify/busboy. npm audit goes from 33 advisories to 0, which clears
the 51 Dependabot alerts on this lockfile.

Tested with a real prebuilt preview deploy to vortex-explorer, installed
with npm ci --ignore-scripts and run with the workflow's flags. The
deploy reached READY, served the site and the wasm, and recorded its
commit metadata.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.82%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 1 improved benchmark
✅ 2317 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Walltime threshold_avx2[80] 3 µs 2.7 µs +10.82%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wm/vercel-cli-overrides (064453b) with develop (b8a2095)

Open in CodSpeed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T21:21:30.818433Z 064453b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@connortsui20 connortsui20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely we wont be victim to a supply chain attack!

@connortsui20
connortsui20 merged commit 0abc850 into develop Oct 29, 2026
137 of 139 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 064453bcec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/vercel-cli/package.json Resolved
@connortsui20
connortsui20 deleted the wm/vercel-cli-overrides branch October 29, 2026 21:21

This branch was successfully deployed

2 active deployments
vercel-explorer — 064453bc Deployed Oct 29, 2026 by lwwmanning via Deploy to Vercel / Deploy #16736
vercel-docs — 064453bc Deployed Oct 29, 2026 by lwwmanning via Publish preview / Deploy #6574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants