Conversation
Choosing an entry copied it, but when the target app had quit or Accessibility was missing the paste silently never happened. Now it beeps, or asks for Accessibility once, like Paste as Plain Text.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picking an entry in the clipboard history window copies it and then sends ⌘V to the app that was in front. When that app had quit, or Vorssaint had no Accessibility permission, the paste never happened and nothing said so.
Now it beeps when the target app is gone. Without Accessibility it opens the system prompt once, then beeps on later tries, the same way Paste as Plain Text handles it since #186. The entry is still copied in both cases, so ⌘V by hand works.
Verification
./build.sh --test: TESTS OK (61,541 checks). The new checks run the production quick paste with a test app and Accessibility grant and fail without the fix: a quit app beeps, a missing grant prompts once and then beeps../build.sh: compiles and links with 0 warnings.Related issues
Refs #937