Conversation
Swift does not warn about unused private functions and constants, so these were left behind when their callers moved to other helpers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes six
private/fileprivatedeclarations that nothing references. Swift does not warn about unused private functions or constants, so these were left behind when their callers changed:App/MenuBarRenderer.swiftmetricItems(for:metrics:preset:)(128 lines)MetricItemstays in use.Services/Switcher/WindowActivator.swiftrestoreSourceAfterTargetMinimize(_:)restoreSourceAfterTargetMinimizeIntent.SwitcherSupport.shouldRestoreSourceAfterTargetMinimizeis still used there.App/StatusItemController.swiftmaxPlacementGenerationStatusItemPlacementSupport.maxPlacementGenerationis read.UI/Settings/HomebrewSettings.swiftupdateHelp(_:)PanelHomebrewView.UI/Media/MediaWorkspaceView.swiftsetInput(_:)setInputs(_:).UI/Settings/RadialMenuVisualCanvas.swiftchipSizeRadialMenuLayout.chipSize.No behavior changes: each removed symbol was private to its file, and the build shows nothing referenced them. Net: 160 lines deleted, nothing added.
I found these by scanning
Sources/for private declarations whose name appears only once in their file, then checkedTests/andgenerate_sources.pyfor references by name. A second scan after the removal found no newly orphaned private declarations.Verification
./build.sh --dev: 0 warnings../build/VorssaintDeveloper --selftest:SELFTEST OK, on MacBookPro18,3, macOS 26.6.2../build.sh --test: 61,538 checks, the same count asmain, with 17 failures. They are the same 17 cases (NotchCompactTests.swift:251andSwitcherScrollTests.swift:163) that fail on an untouchedmainwhile this Mac's screen is locked.mainpassed all of them before the lock.git diff --check: clean.