Conversation
A refused event tap only stopped the service, so the Super key page showed neither the working line nor a warning. It now sets a mapping failure that tells the user how to renew the Accessibility grant.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When macOS refused to create the Super key's keyboard event tap, the service only set itself to not running. The Super key page then showed nothing at all: no "Working now" and no warning, so the key just did nothing. A refused tap is now reported through the existing mapping failure line on the page, with a new reason that tells the user to turn Vorssaint off and on under Privacy & Security › Accessibility and switch the key on again. The new string is translated in all 13 languages.
Verification
./build.sh --test: TESTS OK (61,540 checks). A new contract runs the real tap thread body with a stand-in that refuses the event tap, and checks the key stops and the page gets the new reason../build.sh: compiles and links with 0 warnings.